TheSaaS - Html

Bug in grunt file


toshinobu
toshinobu Purchased - Supported
6 months ago

Lines 65-83 in gruntfile.js are missing the correct file destinations for its .scss files.

The correct file destinations should read:

style_expanded: {

        options: {

          sourceMap: true,

          outputStyle: 'expanded'

        },

        files: {

          'src/assets/css/style.css': 'src/assets/css/scss/style.scss'

        }

      },


      style_compressed: {

        options: {

          sourceMap: true,

          outputStyle: 'compressed'

        },

        files: {

          'src/assets/css/style.min.css': 'src/assets/css/scss/style.scss'

        }

      }


There is also no style.scss in css/scss... it has to be manually created.

toshinobu
toshinobu Purchased - Supported
6 months ago

Found another bug on lines 94 and 95... highlighted sections are missing.

watch: {

      sass_app: {

        files: ['src/assets/css/**/*.scss'],

        tasks: ['sass:app_expanded', 'sass:app_compressed']

      },

      sass_style: {

        files: ['src/assets/css/**/*.scss'],

        tasks: ['sass:style_expanded', 'sass:style_compressed']

      },

....

}

TheThemeio
TheThemeio
6 months ago

Thanks for reporting this problems. But as you can see, those lines are all commented and they don't run anytime!

We wrote those codes because we wanted to provide a style.scss to write custom css inside. But finally we decide to only include style.css in the download package for the sake of simplicity. The code is still there so professional users can uncomment the lines and use a SCSS file for their custom CSS.


Hossein Shams

CEO and Developer at TheTheme.io

toshinobu
toshinobu Purchased - Supported
6 months ago

I understand those lines are commented out. However, if someone uncomments those lines because they want to do their own custom style.css using SASS then I believe I can speak on behalf of all developers when I say we expect those uncommented lines to work as expected. We shouldn't have to do any debugging to figure out why style.css and style.min.css are not being generated from our style.scss file.

TheThemeio
TheThemeio
6 months ago

I see your point. You're right. We'll release an update in a couple of days and fix this issue.

FYI, v1.2.0 is queued for review on Themeforest, so practically the fix is not included in the next update. It'll fix in v1.2.1 which will release a couple of days later.


Hossein Shams

CEO and Developer at TheTheme.io




You should login to be able to write a reply.